refactor: refactor sharded wal to handle coordinator by BioPhoton · Pull Request #1237 · code-pushup/cli

BioPhoton · 2026-02-03T18:35:42Z

Precondition:

refactor: simplify trace types and helper #1236

Implement performance profiling and trace file generation #1197

This PR includes:

split sharded wal logic
handle coordinator in sharder

Followup:

refactor: use sharded WAL #1231

nx-cloud · 2026-02-03T18:36:44Z

View your CI Pipeline Execution ↗ for commit 674fe70

Command	Status	Duration	Result
`nx run-many --target=build --parallel=3`	✅ Succeeded	35s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-24 12:43:44 UTC

…rdinator-in-sharded-wal

# Conflicts: # packages/utils/src/lib/wal.ts # packages/utils/src/lib/wal.unit.test.ts

…-sharded-wal' into feat/utils/handle-coordinator-in-sharded-wal

pkg-pr-new · 2026-02-17T11:42:53Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1237

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1237

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1237

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1237

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1237

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1237

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1237

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1237

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1237

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1237

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1237

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1237

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1237

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1237

commit: 674fe70

github-actions · 2026-02-23T08:47:07Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 069d350 with previous commit 4c80af5.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 33	🔴 36
Documentation	🟡 53	🟡 53
Code coverage	🟢 93	🟢 93
Bug prevention	🟡 75	🟡 75
Axe Accessibility	🟡 88	🟡 88
Code style	🟢 100	🟢 100	–
Security	🔴 0	🔴 0	–
Updates	🟡 72	🟡 72	–
Type Safety	🟡 67	🟡 67	–
Miscellaneous	🟡 67	🟡 67	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 97	🟢 97	–
SEO	🟢 92	🟢 92	–

👍 2 groups improved, 👎 1 group regressed, 👍 9 audits improved, 👎 3 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
Lighthouse	Performance	🔴 33	🔴 36
JSDocs coverage	Documentation coverage	🟡 53	🟡 53
Code coverage	Code coverage metrics	🟢 93	🟢 93

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	Speed Index	🟥 7.0 s	🟥 6.4 s
Lighthouse	First Contentful Paint	🟥 3.4 s	🟥 3.1 s
Lighthouse	Total Blocking Time	🟥 2,750 ms	🟥 1,850 ms
JSDocs coverage	Methods coverage	🟨 10 undocumented methods	🟨 10 undocumented methods
JSDocs coverage	Properties coverage	🟥 43 undocumented properties	🟥 47 undocumented properties
Lighthouse	Time to Interactive	🟥 14.4 s	🟥 13.7 s
JSDocs coverage	Variables coverage	🟥 273 undocumented variables	🟥 274 undocumented variables
Code coverage	Branch coverage	🟨 89.2 %	🟨 89 %
Code coverage	Function coverage	🟩 94.4 %	🟩 94.4 %
JSDocs coverage	Types coverage	🟥 264 undocumented types	🟥 265 undocumented types
Code coverage	Line coverage	🟩 92.7 %	🟩 92.7 %
JSDocs coverage	Functions coverage	🟥 585 undocumented functions	🟥 584 undocumented functions
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,136 KiB	🟩 Total size was 2,143 KiB
Lighthouse	Minimizes main-thread work	🟥 13.9 s	🟥 9.9 s
Lighthouse	JavaScript execution time	🟥 5.5 s	🟥 3.5 s
Lighthouse	Largest Contentful Paint	🟥 11.6 s	🟥 10.7 s
Lighthouse	Uses efficient cache policy on static assets	🟨 31 resources found	🟨 31 resources found
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Server Backend Latencies	🟩 1,280 ms	🟩 810 ms
Lighthouse	Max Potential First Input Delay	🟥 1,650 ms	🟥 1,210 ms
Lighthouse	Reduce unused JavaScript	🟥 Potential savings of 255 KiB	🟥 Potential savings of 256 KiB
Lighthouse	Network Round Trip Times	🟩 60 ms	🟩 20 ms
Lighthouse	Reduce unused CSS	🟥 Potential savings of 110 KiB	🟥 Potential savings of 110 KiB
Lighthouse	Remove duplicate modules in JavaScript bundles	🟥 Potential savings of 80 KiB	🟥 Potential savings of 79 KiB
Lighthouse	Initial server response time was short	🟩 Root document took 500 ms	🟩 Root document took 500 ms
JS packages	Vulnerabilities for npm dev dependencies.	🟥 81 vulnerabilities (3 critical, 65 high, 10 moderate, 3 low)	🟥 80 vulnerabilities (3 critical, 64 high, 10 moderate, 3 low)
Lighthouse	Avoids an excessive DOM size	🟥 2,360 elements	🟥 2,359 elements

652 other audits are unchanged.

github-actions · 2026-02-23T09:01:37Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 069d350 with previous commit 4c80af5.

💼 Project `utils`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Documentation	🟡 60	🟡 61
Code coverage	🟢 95	🟢 95

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 5 audits improved, 👎 3 audits regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
JSDocs coverage	Documentation coverage	🟡 60	🟡 61
Code coverage	Code coverage metrics	🟢 95	🟢 95

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDocs coverage	Methods coverage	🟨 10 undocumented methods	🟨 10 undocumented methods
JSDocs coverage	Properties coverage	🟥 40 undocumented properties	🟥 44 undocumented properties
Code coverage	Branch coverage	🟩 91.8 %	🟩 91.2 %
JSDocs coverage	Types coverage	🟨 55 undocumented types	🟨 56 undocumented types
JSDocs coverage	Variables coverage	🟥 49 undocumented variables	🟥 50 undocumented variables
Code coverage	Function coverage	🟩 95.8 %	🟩 95.9 %
JSDocs coverage	Functions coverage	🟥 243 undocumented functions	🟥 242 undocumented functions
Code coverage	Line coverage	🟩 97.8 %	🟩 97.8 %

436 other audits are unchanged.

💼 Project `plugin-lighthouse`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

All of 6 categories are unchanged.

1 audit changed without impacting score

🗃️ Groups

All of 15 groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Branch coverage	🟩 98.8 %	🟩 98.8 %

443 other audits are unchanged.

12 other projects are unchanged.

packages/utils/src/lib/wal.int.test.ts

packages/utils/src/lib/wal-sharded.unit.test.ts

packages/utils/src/lib/wal-sharded.int.test.ts

packages/utils/src/lib/wal-sharded.ts

packages/utils/src/lib/wal.ts

packages/utils/src/lib/wal-sharded.ts

packages/utils/src/lib/wal-sharded.int.test.ts

packages/utils/src/lib/wal-sharded.ts

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

…rdinator-in-sharded-wal

hanna-skryl · 2026-02-24T14:50:51Z

packages/utils/src/lib/wal.unit.test.ts

  });

-  it('repacks with invalid entries and logs warning', () => {
+  it('repacks with without invalid entries and logs warning', () => {


Suggested change

it('repacks with without invalid entries and logs warning', () => {

it('repacks without invalid entries and logs warning', () => {

hanna-skryl · 2026-02-24T14:52:36Z

packages/utils/src/lib/wal-sharded.ts

+   * @param opt.groupId - Group ID for sharding (defaults to generated group ID)
+   * @param opt.coordinatorIdEnvVar - Environment variable name for storing coordinator ID (defaults to CP_SHARDED_WAL_COORDINATOR_ID)
+   * @param opt.autoCoordinator - Whether to auto-set the coordinator ID on construction (defaults to true)
+   * @param opt.measureNameEnvVar - Environment variable name for coordinating groupId across processes (optional)


The constructor signature doesn't have a measureNameEnvVar parameter. It is, however, included in tests.

hanna-skryl · 2026-02-24T14:55:38Z

packages/utils/src/lib/errors.ts

+export function extendError(
+  error: unknown,
+  message: string,
+  { appendMessage = false } = {},


The message is prepended, while the cause is appended 🤔

refactor: refactor sharded wal to handle coordinator

ffcc95d

BioPhoton requested a review from hanna-skryl February 3, 2026 18:35

github-actions bot assigned BioPhoton Feb 3, 2026

github-actions bot added 🔬 testing writing tests 🧩 utils labels Feb 3, 2026

BioPhoton removed the request for review from hanna-skryl February 3, 2026 18:37

This was referenced Feb 3, 2026

refactor: simplify trace types and helper #1236

Merged

Implement performance profiling and trace file generation #1197

Open

BioPhoton added 2 commits February 8, 2026 22:24

Merge remote-tracking branch 'origin/main' into feat/utils/handle-coo…

cc0b481

…rdinator-in-sharded-wal

refactor: wip

aa0395f

github-actions bot added the 🛠️ tooling label Feb 8, 2026

BioPhoton added 2 commits February 17, 2026 18:09

Merge branch 'main' into feat/utils/handle-coordinator-in-sharded-wal

000be48

# Conflicts: # packages/utils/src/lib/wal.ts # packages/utils/src/lib/wal.unit.test.ts

Merge remote-tracking branch 'origin/feat/utils/handle-coordinator-in…

234a83b

…-sharded-wal' into feat/utils/handle-coordinator-in-sharded-wal

github-actions bot removed the 🛠️ tooling label Feb 17, 2026

BioPhoton added 3 commits February 17, 2026 18:34

refactor: wip

eddf9cc

refactor: wip

f8f2847

refactor: wip

14e6390

BioPhoton added 5 commits February 17, 2026 20:47

refactor: wip

75ccc48

refactor: update const name

2d94b12

refactor: fix int tests

6719873

refactor: fix unit tests

2e8910b

refactor: fix lint

d150c70

BioPhoton mentioned this pull request Feb 23, 2026

refactor: use sharded WAL #1231

Open

BioPhoton marked this pull request as ready for review February 23, 2026 08:53

BioPhoton requested a review from hanna-skryl February 23, 2026 08:53

hanna-skryl reviewed Feb 23, 2026

View reviewed changes

BioPhoton and others added 12 commits February 23, 2026 16:16

Update packages/utils/src/lib/wal.int.test.ts

b46e330

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Update packages/utils/src/lib/wal-sharded.int.test.ts

ca1c0c8

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Update packages/utils/src/lib/wal-sharded.int.test.ts

0e72e8c

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Update packages/utils/src/lib/wal-sharded.unit.test.ts

d2e885d

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Update packages/utils/src/lib/wal-sharded.ts

55816b9

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into feat/utils/handle-coo…

287c134

…rdinator-in-sharded-wal

refactor: adjust groupID handling

8e9aeeb

refactor: fix comment

ba94649

refactor: fix naming

270d3ec

refactor: comment helper

ce3ea34

refactor: comment adjustments

f32147d

refactor: adjust dir creation

674fe70

BioPhoton requested a review from hanna-skryl February 24, 2026 12:41

hanna-skryl reviewed Feb 24, 2026

View reviewed changes

	it('repacks with without invalid entries and logs warning', () => {
	it('repacks without invalid entries and logs warning', () => {

Comments

Conversation

BioPhoton commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

Uh oh!

github-actions bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

💼 Project utils

🗃️ Groups

🛡️ Audits

💼 Project plugin-lighthouse

🗃️ Groups

🛡️ Audits

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hanna-skryl Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BioPhoton commented Feb 3, 2026 •

edited

Loading

nx-cloud bot commented Feb 3, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 17, 2026 •

edited

Loading

github-actions bot commented Feb 23, 2026 •

edited

Loading

github-actions bot commented Feb 23, 2026 •

edited

Loading

💼 Project `utils`

💼 Project `plugin-lighthouse`